Fix "My devices" dropdown when group devices are shown #21983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cedric-anne
force-pushed
the
11.0/fix-my-group-devices
branch
from
c62cae1 to
0948546
Compare
trasher
reviewed
Dec 1, 2025
tests/functional/DropdownTest.php
Outdated
| return [ | ||
| [\CartridgeItem::class], [Computer::class], [\ConsumableItem::class], [Monitor::class], [\NetworkEquipment::class], | ||
| [\Peripheral::class], [\Phone::class], [\Printer::class], [\Software::class], | ||
| [\Peripheral::class], [\Phone::class], [Printer::class], [\Software::class], |
Contributor
There was a problem hiding this comment.
Why not import every class?
trasher
reviewed
Dec 1, 2025
tests/functional/DropdownTest.php
Outdated
| ); | ||
|
|
||
| // Create test equipment owned by user/group using GLPI's createItem helper | ||
| $computer_1 = $this->createItem('Computer', [ |
Contributor
There was a problem hiding this comment.
Suggested change
| $computer_1 = $this->createItem('Computer', [ | |
| $computer_1 = $this->createItem(Computer::class, [ |
(for all hardcoded itemtypes)
trasher
approved these changes
Dec 2, 2025
AdrienClairembault
approved these changes
Dec 2, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
It fixes #21953